Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grcov URL on macos and upload gcov binaries #1757

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Fix grcov URL on macos and upload gcov binaries #1757

merged 1 commit into from
Nov 9, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented Nov 9, 2018

Problems

  • 404 if tried to run test-nightly.sh on macos. grcov is pointing to a URL with darwin instead of osx
  • @marco-c had offerred to help us debug grcov if we could get him the gcno files, but they aren't uploaded as build artifacts.

Summary of Changes

  • Fix macos download URL for grcov
  • Upload gcna and gcno files to Buildkite

cc #433

@garious garious changed the title Fix grcov download on macos and upload gcda/gcdo files for debugging Fix grcov URL on macos and upload gcov binaries Nov 9, 2018
@garious garious merged commit 0926702 into solana-labs:master Nov 9, 2018
@snyk-bot snyk-bot mentioned this pull request Jun 9, 2021
Open
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
@jordaaash
lending: use Pyth as oracle (solana-labs#1757)
4ffc2f6
brooksprumo pushed a commit to brooksprumo/solana that referenced this pull request Jun 17, 2024
@buffalojoec
SVM: update spec (solana-labs#1757)
aae4b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garious @solana-grimes @sagar-solana